search

cube1us / IBM1410SMS

Database Program for capturing data from IBM SMS Automated Logic Diagrams and related database layer
GNU General Public License v3.0
0 stars 0 forks source link

EditCardLocationForm should warn if more than one card location page found in the database for a given page name for a given machine. #17

Closed cube1us closed 4 years ago

cube1us commented 4 years ago

EditCardLocationForm should warn if more than one card location page found in the database for a given page name for a given machine. (Test to see what actually happens)

cube1us commented 4 years ago

The duplicates seem to be coming from this same form with the message "Added Via Card Location Block Reference". That should not be happening. It appears to happen when the same page is mentioned twice when adding a new card location chart block. (It is also implying it is adding them with a ZERO volume key - but that does not appear to be the case - that message is bogus.)

cube1us commented 4 years ago

ZERO volume key part of message was bogus - the volume key may (or may not) be filled in. This message should only be present when it is not filled in.

The rest is in progress -- tricksy.

cube1us commented 4 years ago

Fixes completed. (Note: it was actually possible to intentionally add a duplicate page using the EditCardLocationPageForm, so I was able to test the original issue, as well as test cases where this dialog was itself adding duplicate pages. I left EdtCardLocationPageForm as is - i.e. it is still possible to create duplicates that way. Also, EditDiagramPageForm and EditCableEdgeConnetionPageForm also allow adding such duplicates.