search

cube1us / IBM1410SMS

Database Program for capturing data from IBM SMS Automated Logic Diagrams and related database layer
GNU General Public License v3.0
0 stars 0 forks source link

New pages often get assigned to the wrong volume, especially by Edit Card Location #50

Closed cube1us closed 4 years ago

cube1us commented 4 years ago

New pages often get assigned to the wrong volume, especially by Edit Card Location, and can end up associated with completely different machines' volume sets.

Because volumes are not tied to machines, one cannot check directly at least EditCardLocationForm is doing. The following changes should be made:

1) In EditCardLocationForm, when a new page is created by the datagridview, when applying the update, check for a page that is in a volume that is in the selected volume set (associated with the selected volume entry) and is in range for the page name entered. If none are found, that should be an error to prevent later data entry problems.

2) In EditCardLocationPageForm, EditDiagramPageForm and EditCableEdgeConnectionPageForm to check the selected volume for a page range match and warn (but allow an override) if it doesn't match.

cube1us commented 4 years ago

Fixed in EditCardLocationForm. Will look at the others later. It first looks within the volume set that comprises the new page's name, then looks for volume Unassigned in the volume set, then finally adds a volume Unassigned to the current volume set.

cube1us commented 4 years ago

Fixed. NOTE however, that the "range check" is currently just a string check, so compares can fail if the page names don't follow the same convention as those used for the ranger in the volume table row. If some care is used in selecting those ranges, it should be fine. Also, the range check is just a warning.