cube2222 / octosql

OctoSQL is a query tool that allows you to join, analyse and transform data from multiple databases and file formats using SQL.
Mozilla Public License 2.0
4.75k stars 202 forks source link

Order by streaming #240

Closed Risers closed 4 years ago

Risers commented 4 years ago

I'm okay with the changes now, but 1 last thing I didn't think about previously, we are holding recordcount and recordvalue separately, couldn't we just keep a single map recordValue -> recordCount?

We probably could do it but then but then we would have to extract value from serialized map key, which is more than just record value. It may decrease code readability.