cube2222 / octosql

OctoSQL is a query tool that allows you to join, analyse and transform data from multiple databases and file formats using SQL.
Mozilla Public License 2.0
4.74k stars 201 forks source link

Switch $HOME/.octosql to XDG Spec #308

Closed tony-sol closed 1 year ago

tony-sol commented 1 year ago

Change default configs/plugins/repos/logs location according to XDG Specification.

App will look for:

tony-sol commented 1 year ago

Awesome! Thanks so much!

Should i do anything else to make new release available?

cube2222 commented 1 year ago

@Tony-Sol snapshot tests started failing, so will need to debug that before making a release.

cube2222 commented 1 year ago

Yeah, trying out locally, it looks like it's not capable of creating the logs file if the ~/.octosql home directory doesn't exist (it should create it).

couldn't create logs file: open /Users/jakub/.octosql/logs.txt: no such file or directory
tony-sol commented 1 year ago

I'm going to debug this now, fix will be soon

cube2222 commented 1 year ago

@Tony-Sol I think it's the change in InitializeFileLogger

cube2222 commented 1 year ago

used to have MkdirAll, now it doesn't

cube2222 commented 1 year ago

Pushed a fix https://github.com/cube2222/octosql/commit/b158983ae886ce316636f3f9cdb1a68756dca127

tony-sol commented 1 year ago

@cube2222 made a new PR with fix - https://github.com/cube2222/octosql/pull/315