Closed tony-sol closed 1 year ago
Awesome! Thanks so much!
Should i do anything else to make new release available?
@Tony-Sol snapshot tests started failing, so will need to debug that before making a release.
Yeah, trying out locally, it looks like it's not capable of creating the logs file if the ~/.octosql home directory doesn't exist (it should create it).
couldn't create logs file: open /Users/jakub/.octosql/logs.txt: no such file or directory
I'm going to debug this now, fix will be soon
@Tony-Sol I think it's the change in InitializeFileLogger
used to have MkdirAll, now it doesn't
@cube2222 made a new PR with fix - https://github.com/cube2222/octosql/pull/315
Change default configs/plugins/repos/logs location according to XDG Specification.
App will look for:
$XDG_CONFIG_HOME/octosql/octosql.yml
with fallback to current$HOME/.octosql/octosql.yml
$XDG_CACHE_HOME/octosql/logs.txt
with fallback to current$HOME/.octosql/logs.txt
$XDG_CACHE_HOME/octosql/tmp/plugins/
with fallback to current$HOME/.octosql/tmp/plugins/
$XDG_CONFIG_HOME/octosql/file_extension_handlers.json
with fallback to current$HOME/.octosql/file_extension_handlers.json
$XDG_DATA_HOME/octosql/plugins
with fallback to current$HOME/.octosql/plugins
$XDG_DATA_HOME/octosql/repositories
with fallback to current$HOME/.octosql/repositories