cube2222 / octosql

OctoSQL is a query tool that allows you to join, analyse and transform data from multiple databases and file formats using SQL.
Mozilla Public License 2.0
4.74k stars 201 forks source link

fix: fix miss makezero bug #334

Open alingse opened 1 month ago

alingse commented 1 month ago

I was running github actions to run linter makezero for top github golang repos.

see issues https://github.com/alingse/go-linter-runner/issues/1

and the github actions output https://github.com/alingse/go-linter-runner/actions/runs/9242658341/job/25425755939

====================================================================================================
append to slice `newPending` with non-zero initialized length at https://github.com/cube2222/octosql/blob/main/outputs/stream/internally_consistent_output_stream_wrapper.go#L2[9](https://github.com/alingse/go-linter-runner/actions/runs/9242658341/job/25425755939#step:4:10):18
====================================================================================================

but the newPending pending convert is complex to understand, maybe this was a feature ?