Code Review: Use of currentPage() When Calling addBreadCrumb()

[bhsmither]

In Catalogue->displayProduct(), there is this:

$GLOBALS['gui']->addBreadcrumb($product['name'], currentPage());

By using currentPage(), the result is an SEO'd path.

Note that in GUI->addBreadCrumb(), when pushing arrays onto $this->_breadcrumb, the 'url' gets SEO'd.

Request that the standard querystring be passed in, or perhaps the $_GET array.

The intent is, in addBreadCrumb(), to use parts of $href for more work.

[bhsmither]

The same request applies toCubeCart->loadPage(), near line 392, regarding the breadcrumb for a document.

[bhsmither]

But be careful. Testing against PCRE_REQUEST_URI (replicated as an actual regex) requires [\w]+\.[a-z]+ (such as index.php), which will not be in $_GET.