search

cubecart / v6

CubeCart Version 6
https://cubecart.com
72 stars 59 forks source link

Code Review: CSS Helpers #3498

Closed bhsmither closed 5 months ago

bhsmither commented 6 months ago

The Foundation CSS ruleset has:

.row .row { margin: 0 0.9375em } // line 142
.row .row.collapse { margin: 0 } // line 151

Then there is the cubecart.helpers.css ruleset.

The question is, how important are these helper rules? Should the helper rules always overrule the Foundation rules?

The Foundation rules have greater specificity than the helper rules.

If the helper rules need to be more important, then they would need the !important designation.

abrookbanks commented 5 months ago

The helper rules shouldn't clash with foundation rules so this shouldn't make a difference. The idea is that these are some extra tools for quick layout jobs. I don't think adding the !important designation should be needed.

abrookbanks commented 5 months ago

I don't think any action needs to be taken here. They load last so should always be available.