search

cubecart / v6

CubeCart Version 6
https://cubecart.com
72 stars 59 forks source link

Unknown Variable #3510

Closed bhsmither closed 5 months ago

bhsmither commented 5 months ago

In settings.index.inc.php, near line 97, the variable $logo_update is checked for being false-like. But, on the first pass through this $_FILES loop, $logo_update does not yet exist. (PHP's empty() also returns true if the variable is not yet set.)

Note that $logo_update is also tested near line 253. Here, currently, $logo_update will be either not set or true.

Maybe, for line 253:

if (!empty($updated) || !empty($logo_update)) {
abrookbanks commented 5 months ago

You bust my balls Brian!! 🤯

abrookbanks commented 5 months ago

I took a slightly different approach.