cubecart / v6

CubeCart Version 6
https://cubecart.com
72 stars 59 forks source link

Code Review: Product Reviews Detail #3514

Closed bhsmither closed 5 months ago

bhsmither commented 5 months ago

In Catalogue->productAssign(), lines that work with catalogue['review_info'] (1679-1683), the true block assigns the language string to Smarty, while the false block sets the $product['review_info'].

Please consider moving the code in the false block out of the if structure and doing away with the false block.

There is no apparent reason why this detail should be missing if $product_view is true - regardless whether or not it would be displayed somewhere.

abrookbanks commented 5 months ago

Good find thanks.