search

cubecart / v6

CubeCart Version 6
https://cubecart.com
72 stars 59 forks source link

Code Check: P Nesting DIV #3515

Closed bhsmither closed 5 months ago

bhsmither commented 5 months ago

In Foundation's element.product.review.score.php, there is a <div> block nested inside a <p> block.

A valid structure cannot have block-level elements inside <p></p>, which can only contain inline elements.

Viewing this code in a debugger will show that, automatically, the <p> block gets closed, then the <div> block is present, then a new (in this case empty) <p></p> block appears.

bhsmither commented 5 months ago

Suggest changing the ratings <p> tags to <div> tags.

The Review Info <div> block could be moved out of the ratings block, or kept nested - it doesn't matter.

Request that the star ratings <div> and the Review Info <div> both be given ID attributes.

abrookbanks commented 5 months ago

Thanks so much.

bhsmither commented 5 months ago

Please note there was a request that the star ratings <div> and the Review Info <div> both be given ID attributes.

abrookbanks commented 5 months ago

Whoops! Done now. Thanks. I'm pleased you QC a lot of these, much appreciated.