cubedro / eth-net-intelligence-api

Ethereum Network Intelligence API
http://tinyurl.com/ofndjbo
GNU General Public License v3.0
327 stars 344 forks source link

update.sh bad way to kill remaining process #238

Open gabx opened 8 years ago

gabx commented 8 years ago
 heading "Killing remaining node processes"
echo `ps auxww | grep node | awk '{print $2}'`
kill -9 `ps auxww | grep node | awk '{print $2}'`

When running this command on my machine, $ ps auxww | grep node | awk '{print $2}', here is the output:

1445
1617
1950
2174
2559
2851
12019

Now see the process:

$ ps -p 1445 -o comm=
slack
ps -ef | grep 1445
261:gabx      1445  1419  0 May03 ?        00:01:21 /usr/lib/slack/slack --type=renderer --no-sandbox --lang=en-US --register-standard-schemes=slack-resources --node-integration=true --preload=/usr/lib/slack/resources/app.asar/src/static/index.js --num-raster-threads=4 --content-image-texture-target=3553,3553,3553,3553,3553,3553,3553,3553,3553,3553,3553,3553,3553 --video-image-texture-target=3553 --disable-accelerated-video-decode --disable-gpu-compositing --channel=1396.0.1432034957 --v8-natives-passed-by-fd --v8-snapshot-passed-by-fd

As you can see, nothing to do with eth process.

5chdn commented 8 years ago

update.sh does really scary stuff. and there should be a warning that this is only for Ubuntu.

It quoted me eight times for root access, which I didn't grant because the heading was something like "removing ethereum" (but not which or what?).

Also, I do not have that ./bin/www directory and it fails at multiple points. Maybe I missed that part in the documentation, but I would not recommend anyone using this script as it is currently.