search

cubehouse / themeparks

Unofficial API for accessing ride wait times and schedules for Disneyland, Disney World, Universal Studios, and many more parks
MIT License
542 stars 125 forks source link

Fixes MerlinParks FetchOpeningTimes #154

Closed jeanmatthieud closed 5 years ago

jeanmatthieud commented 5 years ago

Fixes OpeningTime fetching error for AltonTowers and ThorpePark.

Side note: ThorpePark is still in error for waiting times.

cubehouse commented 5 years ago

Thank you so much for your pull requests. I'm on a long vacation at the moment, so will try and get these merged in when I can.

jeanmatthieud commented 5 years ago

No problem. I stopped the publication of ChronoPass 2 years ago (not enough time to maintain it). I'm building a new version, and I'm using your library again 👍

I will try my best to update the non-working parks. I also don't know what are your plans about the v5, and how I can help you with it. As I want to be able to maintain my app, I will be happy to help you as much as I can. I'm doing that in my spare time, so I will not be as reactive as I would like to be.

cubehouse commented 5 years ago

v5.0 is my next thing to finish, which I hope to get finished in a month or so. It's mostly a rewrite of the library in modern JS, so no stupid ".bind(this)" everywhere and just cleaner syntax, which hopefully makes it easier to understand and maintain. It will also remove support for older NodeJS versions, so I can stop using Babel to back-port features using the build/ directly, and now npm will just have the raw modern JS code.

5.0 also uses the new live WDW API (I suspect the current API 4.0 is using will be deprecated at some point), so I plan to update the library to fire events when ride times change, rather than having to manually request updates when you want them (both options should be supported, with the library polling in the background for non-live parks).

It's mostly an opportunity to rewrite a bunch of stuff and tidy up things in the API I wish were different :)