search

cubehouse / themeparks

Unofficial API for accessing ride wait times and schedules for Disneyland, Disney World, Universal Studios, and many more parks
MIT License
543 stars 126 forks source link

Add facilityCode to TDR wait time meta property #245

Closed rorpage closed 4 years ago

rorpage commented 4 years ago

Addresses #244

rorpage commented 4 years ago

Sorry for all of the noise. I accidentally committed a Visual Studio file and then squashed my history to get rid of it.

cubehouse commented 4 years ago

Thank you for this!

Instead of overriding the UpdateRide function, can you add a meta object to the rideData object in FetchWaitTimes?

const rideData = {
    // ride name
    name: rides[ride.id].name,
    meta: {
        facilityCode: rides[ride.id].facilityCode,
    },
};
rorpage commented 4 years ago

@cubehouse I have addressed your feedback!

cubehouse commented 4 years ago

Brilliant thank you! If you can make the linter happy with some trailing commas then I will merge this in.

You can test the linter "npm run lint" if your IDE doesn't pick up on the linter rules automatically.

rorpage commented 4 years ago

@cubehouse :boom: there we go

cubehouse commented 4 years ago

Thank you, pushed in 5.1.24