search

cubehouse / themeparks

Unofficial API for accessing ride wait times and schedules for Disneyland, Disney World, Universal Studios, and many more parks
MIT License
545 stars 126 forks source link

Change language to French for rides #249

Closed LouisForaux closed 5 years ago

LouisForaux commented 5 years ago

Fix French language for rides

cubehouse commented 5 years ago

I would like to keep ride names in English by default where possible. This is consistent with the parks we support in China/Japan etc. You can add a constructor option if you want.

cubehouse commented 5 years ago

Could you put this:

this[sApiLang] = options.lang || 'en-gb';

in the base class, so the default is English. Then don't have them manually set in the two park implementations (setting options.lang will fall-through to the base class)?

Also you currently have it set to English for MK and French for DS :)

LouisForaux commented 5 years ago

Yes ! It's done ! Sorry for the mistake between WDS and MK :D (I've made the test with the two languages)