cubehouse / themeparks

Unofficial API for accessing ride wait times and schedules for Disneyland, Disney World, Universal Studios, and many more parks
MIT License
545 stars 126 forks source link

Tokyo Disney Parks return error #277

Closed dotaguro closed 4 years ago

dotaguro commented 4 years ago

Park Both Tokyo Disney parks.

Context

How to find your themeparks version: Linux: npm list --depth=0 | grep themeparks Windows CMD: npm list | find "themeparks" PowerShell: npm list | sls themeparks

Describe the bug Fetching Tokyo Disney times returns: 404: { "type": "Buffer", "data": [] }

Output THEMEPARKS 40644: TokyoDisneyResortMagicKingdom: Set useragent to TokyoDisneyResortApp/1.1.7 Android/9 THEMEPARKS 40644: Making request to https://api-portal.tokyodisneyresort.jp/rest/v1/facilities THEMEPARKS 40644: Calling GET:https://api-portal.tokyodisneyresort.jp/rest/v1/facilities THEMEPARKS 40644: Network request failed attempt 1/3 for URL https://api-portal.tokyodisneyresort.jp/rest/v1/facilities THEMEPARKS 40644: 404: { "type": "Buffer", "data": [] } THEMEPARKS 40644: Calling GET:https://api-portal.tokyodisneyresort.jp/rest/v1/facilities THEMEPARKS 40644: Network request failed attempt 2/3 for URL https://api-portal.tokyodisneyresort.jp/rest/v1/facilities THEMEPARKS 40644: 404: { "type": "Buffer", "data": [] } THEMEPARKS 40644: Calling GET:https://api-portal.tokyodisneyresort.jp/rest/v1/facilities THEMEPARKS 40644: Network request failed attempt 3/3 for URL https://api-portal.tokyodisneyresort.jp/rest/v1/facilities THEMEPARKS 40644: 404: { "type": "Buffer", "data": [] } Magic Kingdom - Tokyo Disney Resort is borked: 404: { "type": "Buffer", "data": [] }

dotaguro commented 4 years ago

Looks like the API has changed in a big way again.

I did notice that https://www.tokyodisneyresort.jp/_/realtime/tdl_attraction.json and https://www.tokyodisneyresort.jp/_/realtime/tds_attraction.json both return ride time information without any special logic... you can just curl/wget it and get back JSON, but the attraction names are in Japanese.

Might be worth not trying to emulate the app anymore... snarfing the english ride names using the existing GetEnglishNames() method and combining with these easily accessible JSON pages might be the best approach?

SomethingWithComputers commented 4 years ago

I'm in the same boat right now. Tokyo Disney keeps changing their API. Not sure if I should migrate to a self-made solution that retrieves, translates, and stores the relevant data from the JSON API. I believe this can be fixed though. If somebody can point me to the right place to start, I'd be happy to attempt an implementation.

cubehouse commented 4 years ago

I've not had any time to look at this. Will be happy to accept a Pull Request though if anyone writes an implementation.

Tokyo source is in lib/disneytokyo/: https://github.com/cubehouse/themeparks/blob/master/lib/disneytokyo/disneyTokyoBase.js

dotaguro commented 4 years ago

I'm trying to work on it, but I'm a bit swamped right now so it might be a couple weeks before I have a PR.

On Mon, Feb 10, 2020 at 1:31 PM Jamie Holding notifications@github.com wrote:

I've not had any time to look at this. Will be happy to accept a Pull Request though if anyone writes an implementation.

Tokyo source is in lib/disneytokyo/: https://github.com/cubehouse/themeparks/blob/master/lib/disneytokyo/disneyTokyoBase.js

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cubehouse/themeparks/issues/277?email_source=notifications&email_token=AAAVTOV5V5VHRIQCKGDS5TLRCHBS7A5CNFSM4KRPNN2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELKLVEY#issuecomment-584366739, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVTOROIDVJPR6HWRSHXMDRCHBS7ANCNFSM4KRPNN2A .

nearprosmith commented 4 years ago

Hmmm... it is big change and I'm wondering if this way is the best method... but I will attempt simple curl way implementation.

nearprosmith commented 4 years ago

I fixed it an simpler way.

cubehouse commented 4 years ago

Thank you all, this is now live in 5.1.34!