search

cubehouse / themeparks

Unofficial API for accessing ride wait times and schedules for Disneyland, Disney World, Universal Studios, and many more parks
MIT License
545 stars 126 forks source link

Readd Support for Heidepark as of #281 #348

Closed Alpakat closed 3 years ago

Alpakat commented 3 years ago

I changed the API used by heidepark.js as discussed in #281. I also had to change http.js to set the requestData to null if nether options.data or options.body are provided, as {} would result in an "unauthorised" error. I improved the readme too, by adding code fencing to allow syntax highlighting, as this improves the readability.

(I hope, I did everything correct, as this is my first real PR ;)

cubehouse commented 3 years ago

Hi!

Thank you for your pull request.

A bit of guidance, please don't mix multiple changes into the same pull request. While some readme improvements are nice, it isn't good practice to merge multiple things in with the same change. If I don't want to take the changes for the readme, I now cannot take the entire pull request.

Could you remove the readme change and squash the branch?

Thanks

Alpakat commented 3 years ago

Hey, thanks for your response. Thanks also for your advice. I’m sorry, I put the two changes in one pull request, as the thing in the readme was something that annoyed me, while I was reading it the first time. But yea, I now understand your point. I didn’t think of it, doing the pull request, as it is my first “real” pr, but I hope, I fixed it now.

Best regards.