search

cuberat / Pod-POM-View-Restructured

CPAN module Pod::POM::View::Restructured
1 stars 2 forks source link

item list is not made into an rst list #4

Closed wdpypere closed 5 years ago

wdpypere commented 6 years ago

A proper rst list should be prefixed with -. eg:

- item 1
- item 2

However this is not the case.

Example pod:

=pod

=over

=item item1

=item item2

=back

=cut

output:

pod2rst --infile test.pod

item1

item2
alexm commented 6 years ago

Thanks for raising up this issue. Would you like to propose a test for this so we can check it's fixed and it won't regress later? I can guide you through the process if you need.

wdpypere commented 6 years ago

I have never done any perl code, let alone testing so I don't know if that is a good idea. :) What would you expect as a test?

alexm commented 6 years ago

It should be pretty straight forward to add a new test file similar to t/01convert.t that checks that the output is OK for the example you wrote above.

If you'd like to learn how to do it, I can assist you. Otherwise, I'll take care of it, no problem. I'm just giving you the chance to try if you're interested :smile:

wdpypere commented 6 years ago

@alexm I made an attempt in #5

alexm commented 6 years ago

@wdpypere looks good to me. Nice job! :clap:

I will try to fix it this weekend. Thanks a lot.

wdpypere commented 5 years ago

@alexm any news on how me might proceed to get this fixed?

alexm commented 5 years ago

@wdpypere I'm working on a fix in #7. I'll release a new version to CPAN soon, but first I have to check that this fix doesn't break anything on my setup.

Can you check if this fix works for you too?

wdpypere commented 5 years ago

@alexm I tested your fix on our code base and at first glance it seems to do exactly what I would expect it to do.

alexm commented 5 years ago

New release 1.000002 uploaded to CPAN, will be hopefully available soon in a mirror near you :wink:

wdpypere commented 5 years ago

@alexm thanks a lot!