search

cuberite / CuberitePluginChecker

Automated script for CI-checking Cuberite plugins
The Unlicense
3 stars 3 forks source link

Added simple cUrlClient callbacks implementation #16

Closed NiLSPACE closed 8 years ago

NiLSPACE commented 8 years ago

Requires https://github.com/cuberite/cuberite/pull/3407

madmaxoft commented 8 years ago

You should also add the new file to the APIImpl/All.lua list file. That will, among others, load it in the CI.

NiLSPACE commented 8 years ago

Do you mind if I change all.lua to load all files in the current folder automagically with something like this: http://stackoverflow.com/questions/21416798/lua-global-variable-containing-path-to-current-file

madmaxoft commented 8 years ago

Go ahead and make the APIImpl/All.lua file load everything in the APIImpl folder (except for itself, obviously). There's even no need to query the script's folder, since it will be always the same, the Checker is designed to run from its home folder, it will not work when called from other folders.

madmaxoft commented 8 years ago

Oh, this is gonna be fun, having to compile openssl on all my machines...

NiLSPACE commented 8 years ago

I can make it so you simply can't test https if you are missing the luasec library if you'd like.

NiLSPACE commented 8 years ago

Done. I've decided not to automatically find the path for All.lua. I had a little trouble with debug.getinfo

NiLSPACE commented 8 years ago

I suppose you'll want to wait merging this until you've got OpenSSL working?

madmaxoft commented 8 years ago

I can make it so you simply can't test https if you are missing the luasec library if you'd like.

No, I don't want to have multiple "versions" of the Checker, based on what's installed. I can take care of my systems, you in the meantime take care of the CI. It needs the libssl-dev system package installed before installing the luasec rock.

NiLSPACE commented 8 years ago

It still won't install luasec.

madmaxoft commented 8 years ago

Strange, that helped on my Linux box. I'll try to SSH into the build machine to see if I can find what's wrong.

madmaxoft commented 8 years ago

Use this command to install luasec on the CI machine:

sudo luarocks install luasec OPENSSL_LIBDIR=/usr/lib/x86_64-linux-gnu
NiLSPACE commented 8 years ago

It's working!

NiLSPACE commented 8 years ago

Since https://github.com/cuberite/cuberite/pull/3407 is not yet merged it failed, but otherwise it would've succeeded.

madmaxoft commented 8 years ago

Funny, I've (finally) seen the StarWars movies just this weekend :)

That PR should not be needed, the IsOptional attribute should be enough. I'll have a look at what's wrong here.

NiLSPACE commented 8 years ago

I believe it's normal. The first syntax accepts an url and a table (with optional arguments), while the other accepts an url and a function.

NiLSPACE commented 8 years ago

I suppose we have to wait a day to wait for the new ManulAPI, or do you want to merge it as is?

madmaxoft commented 8 years ago

I've triggered a new Jenkins build, it should be complete within 10 minutes and then we can restart the CI build here.

madmaxoft commented 8 years ago

(we're already using the API descriptions from the official buildservers, they come from the Win64 Master build)

madmaxoft commented 8 years ago

And I've got LuaSec working on my main computer, so we should be all good.

NiLSPACE commented 8 years ago

Great :)

madmaxoft commented 8 years ago

Are you using ZeroBraneStudio for the Lua development? If so, consider installing the StripTrailingWhitespace package: https://github.com/pkulchenko/ZeroBranePackage/blob/master/striptrailingwhitespace.lua

NiLSPACE commented 8 years ago

I do use it, but didn't use it for the CuberitePlugin checker. Can I open multiple projects in ZeroBraneStudio at the same time? That way I can keep one open containing WorldEdit and one for the Checker.

NiLSPACE commented 8 years ago

It finished successfully this time :)

madmaxoft commented 8 years ago

It is easy to switch between multiple projects in ZBS, use the "Choose a project directory" button (6th on the toolbar) and navigate to the Checker; then you can use the drop-down next to that button to quickly switch between the last projects. It remembers about 20 last items, so its an okay solution :)

NiLSPACE commented 8 years ago

I'd prefer to keep the two projects open simultaneously in two separate windows if possible.

madmaxoft commented 8 years ago

That won't work properly because of ZBS's debugger - it expects to be listening on a TCP socket, but only one IDE instance can open such a socket. Maybe ask Paul on the ZBS mailing list, he's pretty open to all kinds of suggestions and he might see a solution for you even with the current status - perhaps there's a cmdline param to tell ZBS to listen on another port.