search

cuberite / CuberitePluginChecker

Automated script for CI-checking Cuberite plugins
The Unlicense
3 stars 3 forks source link

Add luacheck in CI #26

Closed madmaxoft closed 7 years ago

madmaxoft commented 7 years ago

Luacheck should be added as another test in the CI.

Seadragon91 commented 7 years ago

This are my current changes in CuberitePluginChecker. I added the file .lauchecrc, install and run luacheck. The file will be added to the plugin directory if the plugin doesn't contain it.

Seadragon91 commented 7 years ago

Current result from circleci.

Edit: The q flag filters out files from output, where luacheck doesn't detect any problems.

madmaxoft commented 7 years ago

This is not what I had in mind when creating this issue. I wanted LuaCheck to actually check this repo, not another plugin. Adding LuaCheck to other plugins is a matter of those plugins, not CuberitePluginChecker.

Also, the CI script is malformed now - consider that all actions listed in the test/override section can be run in parallel next to each other. All the setup needed for the test needs to be done on a single line.

Seadragon91 commented 7 years ago

Ah okay sorry, will create a pull request that adds luacheck and we can discuss there about correcting problems in CuberitePluginChecker.