Open bojmaliev opened 3 years ago
Hello Martin! Thank you for contributing!
I saw that you added Laravel 8 routes which are not backward compatible with older versions of Laravel, so in order to merge your request i need to change composer.json file to change the dependencies.
Basically i will have to make the verstion 3 of the package to require Laravel 8 (which is LTS) and new versions of PHP.
Will do very soon, and merge your fixes!
Thanks again!
Yes I agree about Laravel routes.
Besides that I think we need to fix the critical errors like the one for PSR-4 compatibility. When i tried to install the package I got an error when generating autoload file because of that.
Also there is one more thing I noticed today. When running php artisan nestpay:handle-unprocessed-payments I got an error:
Call to undefined method App\Models\NestpayPayment::toNestpayPaymentObject()
at D:\GitHub\marathon-back\vendor\laravel\framework\src\Illuminate\Support\Traits\ForwardsCalls.php:50
46▕ * @throws \BadMethodCallException
47▕ */
48▕ protected static function throwBadMethodCallException($method)
49▕ {
➜ 50▕ throw new BadMethodCallException(sprintf(
51▕ 'Call to undefined method %s::%s()', static::class, $method
52▕ ));
53▕ }
54▕ }
• Bad Method Call: Did you mean App\Models\NestpayPayment::setInstalment() ?
1 D:\GitHub\marathon-back\vendor\laravel\framework\src\Illuminate\Support\Traits\ForwardsCalls.php:36
Illuminate\Database\Eloquent\Model::throwBadMethodCallException("toNestpayPaymentObject")
2 D:\GitHub\marathon-back\vendor\laravel\framework\src\Illuminate\Database\Eloquent\Model.php:1885
Illuminate\Database\Eloquent\Model::forwardCallTo(Object(Illuminate\Database\Eloquent\Builder), "toNestpayPaymentObject", [])
Hello Bojan,
I've just fixed psr4 problem finally, sorry for the delay this supposed to be our internal package.
Soon I will give support for Laravel 8 and Macedonian currency, thank again for contributing.
PS4-4 autoload error because the class name and file name are not the same Added Macedonian currency Route support for Laravel 8 ENV keys were wrong in the documentation