search

cubewise-code / bedrock

Bedrock is TM1 Best Practice assets built from years of TM1 experience
Other
79 stars 74 forks source link

}bedrock.cube.view.create does not include intermediate children #348

Closed rb524 closed 1 year ago

rb524 commented 1 year ago

Describe the bug The }bedrock.cube.view.create process creates a list of elements used in the view and is set to include all the N level descendants where pSuppressConsol = 1 and includes the consolidated element in the filter where pSuppressConsolStrings = 0, but the intermediate consolidations are not included. This process is called by the }bedrock.cube.data.copy process and results in sting data not being copied for the intermediate consolidations.

To Reproduce Steps to reproduce the behavior: Run the process with a consolidation (which has child consolidations) in the filter and the following parameters 'pSuppressConsol', 1, 'pSuppressConsolStrings', 0,.

Expected behavior I would expect the intermediate consolidations to be included in the view if the filter consolidation is included.

Additional context

Current code image

Suggested fix - Making the test at 345 a IF ELSE

If( ElIsAnc(sDimension, sElement, sEL) = 1 );
    If( pSuppressConsolStrings = 0 );
        SubsetElementInsert(sDimension, sSubset, sEl, 0);
    ElseIf( DType(sDimension, sEl) @<> 'C' );
        SubsetElementInsert(sDimension, sSubset, sEl, 0);
    EndIf;
EndIf;

The If at 352 would stay to put the C elements from the filter into the set as the fix above will only do the intermediate C elements.

lotsaram commented 1 year ago

Fixed in #352