cubewise-code / tm1py

TM1py is a Python package that wraps the TM1 REST API in a simple to use library.
http://tm1py.readthedocs.io/en/latest/
MIT License
190 stars 109 forks source link

Passing kwargs to CellService.execute_mdx_dataframe_pivot #1113

Open bdunleavy22 opened 6 months ago

bdunleavy22 commented 6 months ago

Describe the bug Cannot pass any key word arguments to the function "execute_mdx_dataframe_pivot" in CellService.

To Reproduce try to pass a keyword argument to "execute_mdx_dataframe_pivot". For example, tm1.cells.execute_mdx_dataframe_pivot(mdx, cell_properties=["FormattedValue"])

Expected behavior No Error, keyword argument gets interpreted and returns the result with the given keyword.

Version TM1py 2.0.2 TM1 Server Version: 11.8.02200.2

Additional context Seems like an easy fix of adding ", **kwargs" to the arguments of the function, and to the "return self.extract_cellset_dataframe_pivot( cellset_id=cellset_id, dropna=dropna, fill_value=fill_value, sandbox_name=sandbox_name)" of the function

KaterKoyote commented 4 months ago

I do not know whether this belongs here, but execute_mdx_dataframe_pivot fails if two or more hierarchies from the same dimension are being put on the same df axis. To be precise:

The function CellService.extract_cellset_dataframe_pivot uses dimension_name_from_element_unique_name to extract each row/column name which fails e.g. in the case of hierarchy_unique_name containing [abc].[x] and [abc].[y] (both hierarchy names are simoultaneously being simplified to abc).