cubex2 / BetterFonts

Adds TrueType/OpenType font support for Minecraft.
GNU Lesser General Public License v2.1
37 stars 12 forks source link

Does BetterFonts try to reload JEI or interact with JER? If so, it may be causing a crash due to new JEI API. #13

Open ghost opened 7 years ago

ghost commented 7 years ago

tested with both default san serif and also Kristen ITC

I ran the just enough resources /profile 100 all command with only JEI and JER, it completed and output to files successfully. I then installed betterfonts and ran the command again, and the server hung, I had to kill the process.

Either JER tries outputting in truetype or something weird (why would it use the minecraft font and not the system default?) or when the /profile command tries to complete betterfonts attempts to reload JEI for some reason and hangs the server.

Anyway I would appreciate if you could look into this a bit more? It's able to be worked around by simply disabling better fonts, running the command, than re-enabling. No big deal. :D

workaround #minor

It is possible this isn't your code and it's the Just Enough Resources code. I haven't looked into anything further than the test described here. I don't mind cross posting this to JER if you deem it necessary.

Thanks!

update I have to say I looked through your java source and didn't see anything I understood to be conflicting. I'll go ahead and report this over on JER's site just in-case someone more familiar with the java.lang over here also knows what might be happening. I went ahead and opened an issue at https://github.com/way2muchnoise/JustEnoughResources/issues/114 so that project could look into it.

full log follows https://paste.ee/p/XWxkm

[01:00:19] [Thread-22/INFO] [FML]: Loading dimension -1 (hrk) (net.minecraft.server.integrated.IntegratedServer@15867f66) [01:00:20] [Client thread/INFO]: [CHAT] [Nether] Started profiling [01:00:21] [Thread-22/INFO] [FML]: Loading dimension 1 (hrk) (net.minecraft.server.integrated.IntegratedServer@15867f66) [01:00:22] [Client thread/INFO]: [CHAT] [The End] Started profiling [01:00:22] [Thread-22/INFO] [FML]: Loading dimension 0 (hrk) (net.minecraft.server.integrated.IntegratedServer@15867f66) [01:00:24] [Client thread/INFO]: [CHAT] [Overworld] Started profiling [01:00:26] [Thread-22/ERROR] [jei]: A mod tried to reload JEI, this is no longer supported. See the javadocs for more information java.lang.RuntimeException at mezz.jei.runtime.JeiHelpers.reload(JeiHelpers.java:52) [JeiHelpers.class:?] at jeresources.profiling.Profiler.run(Profiler.java:47) [Profiler.class:?] at java.lang.Thread.run(Unknown Source) [?:1.8.0_131] [01:00:34] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 4430ms behind, skipping 88 tick(s) Process was killed by user.