cubex2 / customstuff4

A Minecraft mod for adding content
https://minecraft.curseforge.com/projects/custom-stuff-4
GNU General Public License v3.0
25 stars 14 forks source link

[missing fetures] compared to CS3 there are some missing block-tags #21

Closed MBelhardi closed 7 years ago

MBelhardi commented 7 years ago

It's missing, compared to custom stuff 3 the following block-tags:

I don't know about the following block-tags, maybe it is possible, but I couldn't find how in the wiki:

MBelhardi commented 7 years ago

at the moment it seems, that the block drops itself, when harvested, even when defined other drops. sure, sometimes the last defined item will drop, but other items defined won't drop... there should be an option to disable block-self-drop

cubex2 commented 7 years ago

You can only define one item at the moment, so it's impossible that the block drops itself if you set the drop to another block.

MBelhardi commented 7 years ago

That exactly what I thought would happen, but than, as I tried to harvest my Block, the first 3 to 4 blocks that dropped were the block itself, and all the other was, as I said, the last defined item, here how I defined it:

    "drop": 
    {
        "0": {"item": "minecraft:coal", "metadata": 1, "amount": 1},
        "0": {"item": "minecraft:stick", "amount": 3}
    },

With this, I have tried to determine if it is possible to define several drops. There was no error, so I tried to harvest the block, with the result I've told.

cubex2 commented 7 years ago

There is no error because the second line just overrides the first one as they have the same key, '0' here. There is no way the dropped block can change after harvesting a few blocks, something else have to happen there.

MBelhardi commented 7 years ago

That's why I brought this up here, I couldn't understand, why the block itself would drop, when I have defined other Items, that should have to drop. Also I couldn't understand why the drop changed. I mean, I did know, that when no charcoal dropped, that the first definition was overwritten by the second, but I can't think of any way, why the block itself could be droped. I even tried to harvest a woll of 4x2x4, every block of this wall dropped itself, not one time there was dropped the defined Item. when I instead harvest a tree-like formation (many blocks over another), then the first 3 to 4 will drop the block itself, the rest will be the defined item. I even tried to take out all other mod's, except for CS4 and forge of course, but the result was the same.

cubex2 commented 7 years ago

Can you provide the complete file of that block?

MBelhardi commented 7 years ago

it's the "charred_wood"-Block, that caused the other problem, you have already closed:

{
    "blocks":
    [
        {
            "type": "block:orientable:directional",
            "entries":
            [
                {
                    "id": "directional",
                    "faceBySide": false,
                    "creativeTab": "dead_world",
                    "material": "iron",
                    "subtypes": [0, 1],
                    "itemModel":
                    {
                        "0": "dead_world:horizontal_0",
                        "1": "dead_world:horizontal_0"
                    },
                    "hardness":
                    {
                        "0": 1,
                        "1": 4
                    }
                }
            ]
        },
        {
            "type": "block:orientable:directional",
            "entries":
            [
                {
                    "id": "charred_wood",
                    "faceBySide": false,
                    "creativeTab": "dead_world",
                    "material": "wood",
                    "subtypes": [0, 1],
                    "drop": 
                    {
                        "0": {"item": "minecraft:coal", "metadata": 1, "amount": 1},
                        "0": {"item": "minecraft:stick", "amount": 3}
                    },
                    "itemModel":
                    {
                        "0": "dead_world:bock_charred_wood"
                    },
                    "hardness":
                    {
                        "0": 1
                    }
                }
            ]
        }
    ]
}

dead_world.zip

cubex2 commented 7 years ago

That shouldn't cause any issues. Tell me if that still happens in the next version.