Open michalbe opened 10 years ago
Totally.
twisty.js
will need some by the time https://github.com/cubing/twisty.js/issues/42 happens. alg.cubing.net
can probably run fine on phantom
, as long as we don't test WebGL.
Have you noticed any regressions in particular?
I haven't really had an issue with them yet, but that's probably because I know the whole project.
(index.html
in twisty.js
has not had as good a fate, but I'm not worrying about it right now.)
Not so far, but forewarned is forearmed. I don't think we want to test WebGL, Three has it's own tests for this and I'm quite sure we can trust them.
+
should be encoded as %2B
so that +
in the URL can be interpreted as a space.Does anyone have a problem with jasmine + karma? Doing a big refactor now. Have some minor tests in place, and don't want to get too deep before someone has problems.
Sounds fine. In any case, no one except me and you is actually active on this project right now.
While project is getting bigger & bigger, it would be nice to have some tests - it will be easier to prevent regressions.