search

cubing / alg.cubing.net

▶️ Multi-purpose puzzle viewer – the old generation of alg/reconstruction viewing and sharing. Superseded by Twizzle.
https://alg.cubing.net
Other
184 stars 32 forks source link

[ALG cubing] Replay animation then user manually scrolls to the end #91

Closed michalbe closed 10 years ago

michalbe commented 10 years ago

Fixes #62 again.

michalbe commented 10 years ago

@lgarron : Ok, the value was just string, parsing it to number helps. Sorry, I don't have a lot of experience with angular.

lgarron commented 10 years ago

Looks good. Could you squash the commits into one?

(Also, I'd remove the , 10, and use parseFloat for consistency.)

lgarron commented 10 years ago

Also, right now the code works because Math.floor($scope.current_move) converts to string. I should probably make things consistent (angular directive for keeping current_move a float, or always use parseFloat before using it.)

lgarron commented 10 years ago

I just fixed this in a bunch of places. Thanks for the PR, even if I didn't take it as-is.