cubing / cubing.js

🛠 A library for displaying and working with twisty puzzles. Also currently home to the code for Twizzle.
https://js.cubing.net/cubing/
GNU General Public License v3.0
232 stars 42 forks source link

Multiple moves happening at the same time in Twizzle Explorer #244

Open GameEntity903 opened 1 year ago

GameEntity903 commented 1 year ago

Steps to reproduce the issue

  1. Open Twizzle Explorer.
  2. Click on the Input Dropdown.
  3. Select the option Keyboard.
  4. Repeat 2 and 3 at least once.
  5. Execute any move.

Observed behaviour

Every keyboard input gives an output multiplied by how many times you repeat the steps above. The dropdown option also does not change to which input mode it is in.

Expected behaviour

The repetitions of the steps should not have the outputs be multiplied and the dropdown should change and show what the current input mode is.

Environment

Version 1.45.116 Chromium: 107.0.5304.91 (Official Build) (64-bit)

🖼 Screenshots

No response

Additional info

No response

lgarron commented 1 year ago

The repetitions of the steps should not have the outputs be multiplied and the dropdown should change and show what the current input mode is.

I agree the current behaviour is confusing. We should definitely improve that.

GameEntity903 commented 1 year ago

Oh yeah, and some other things. 1) Please add M,S and E moves, right now they are showing up as 2R, 2F and 2D respectively. It's kinda confusing. You could implement wide M S and E moves along with it and necessary changes for the larger and smaller cubes. 2) Only if I alternate right click and left-click do the moves cancel each other out (in the algorithm panel). If I repeat the action multiple times and it returns to the solved state it doesn't remove the move altogether which it logically should. And 3R doesn't become R' which it should imo. I tried this in 2x2x2, 3x3x3 and custom and what I said in this point holds true for all three of those.

lgarron commented 1 year ago
  • Please add M,S and E moves, right now they are showing up as 2R, 2F and 2D respectively. It's kinda confusing. You could implement wide M S and E moves along with it and necessary changes for the larger and smaller cubes.

I'll defer to @rokicki on this, as it affects consistency with other puzzles in the explorer.

  • Only if I alternate right click and left-click do the moves cancel each other out (in the algorithm panel). If I repeat the action multiple times and it returns to the solved state it doesn't remove the move altogether which it logically should. And 3R doesn't become R' which it should imo. I tried this in 2x2x2, 3x3x3 and custom and what I said in this point holds true for all three of those.

I think I affected that in a refactor. That should be easy to restore.

lgarron commented 1 year ago
  • Only if I alternate right click and left-click do the moves cancel each other out (in the algorithm panel). If I repeat the action multiple times and it returns to the solved state it doesn't remove the move altogether which it logically should. And 3R doesn't become R' which it should imo. I tried this in 2x2x2, 3x3x3 and custom and what I said in this point holds true for all three of those.

I think I affected that in a refactor. That should be easy to restore.

Okay, this should be fixed.

GameEntity903 commented 1 year ago
  • Only if I alternate right click and left-click do the moves cancel each other out (in the algorithm panel). If I repeat the action multiple times and it returns to the solved state it doesn't remove the move altogether which it logically should. And 3R doesn't become R' which it should imo. I tried this in 2x2x2, 3x3x3 and custom and what I said in this point holds true for all three of those.

I think I affected that in a refactor. That should be easy to restore.

Okay, this should be fixed.

Yep, it's fixed.