Closed lgarron closed 1 year ago
Turns out we were already doing this correctly for Megaminx: https://github.com/cubing/cubing.js/blob/e9063918464b0e563e4166bdde8e237b7b9765fa/src/cubing/search/inside/solve/puzzles/megaminx.ts#L41
So Skewb is the only puzzle that needed a fix.
Steps to reproduce the issue
Alg Tools
>Solve
Observed behaviour
Expected behaviour
The solution is added to the
Moves
field.This issue occurs because https://github.com/cubing/cubing.js/blob/99c378f6c03dcca614096f2a70bccc6250eb01d1/src/cubing/search/inside/solve/puzzles/dynamic/sgs-side-events/skewb.sgs.ts#L22 is a different
KPuzzle
from the regular Skewb def. The easiest fix is probably to also change theKPuzzle
instance to the one used by SGS, here:https://github.com/cubing/cubing.js/blob/99c378f6c03dcca614096f2a70bccc6250eb01d1/src/cubing/search/inside/solve/puzzles/skewb.ts#L32
This probably affects a few other puzzles with custom search defs. (I'm actually a bit surprised it took this long for me to trigger that error! It seems to be rare to accidentally combine transformations from different puzzles.)
Environment
Chrome 107.0.0.0
🖼 Screenshots
No response
Additional info
No response