🛠 A library for displaying and working with twisty puzzles. Also currently home to the code for Twizzle.
GNU General Public License v3.0
245
stars
44
forks
source link
[cubing.js issue] `make test-dist-esm-build-size` size checks are broken. #258
Closed
lgarron closed 1 year ago
Steps to reproduce the issue
make test-dist-esm-build-size
Observed behaviour
Note that 2576kB > 2mB, but in JS the string
"2576kB"
< the number2_000_000
:https://github.com/cubing/cubing.js/blob/1d56924840efe43be8c3a52cb134d42e462112dc/script/test/dist/esm/build-size/main.js#L108
🖼 Screenshots
No response
Expected behaviour
Proper comparison.
Environment
N/A
Additional info
We should:
twsearch
, but I'd like to see a more thorough historical chart).