cubing / cubing.js

🛠 A library for displaying and working with twisty puzzles. Also currently home to the code for Twizzle.
https://js.cubing.net/cubing/
GNU General Public License v3.0
232 stars 42 forks source link

PG3D puzzles render using overly bright colors. #307

Closed lgarron closed 6 months ago

lgarron commented 6 months ago

Observed: custom-1  (1)

Expected: custom-1

This has been bothering me for a while, but it's been tricky to track down. So far, I've narrowed it down to release 152 of three.js: https://github.com/mrdoob/three.js/releases/tag/r152

This enabled ColorManagement by default as of https://github.com/mrdoob/three.js/pull/25866 . This sounds like a pretty plausible reason for brightness changes: https://threejs.org/docs/#manual/en/introduction/Color-management

I've tried setting ColorManagement.enabled = false but that doesn't work, so we probably have to declare color spaces on some PG3D related objects.