🛠A library for displaying and working with twisty puzzles. Also currently home to the code for Twizzle.
GNU General Public License v3.0
232
stars
42
forks
source link
PG3D puzzles render using overly bright colors. #307
Closed
lgarron closed 6 months ago
Observed:![custom-1 (1)](https://github.com/cubing/cubing.js/assets/248078/2dc6c883-66f0-4134-a2d4-5e5e7ab94c44)
Expected:![custom-1](https://github.com/cubing/cubing.js/assets/248078/90515c39-63a6-4abf-8ed6-3a72e3ed51e5)
This has been bothering me for a while, but it's been tricky to track down. So far, I've narrowed it down to release 152 of
three.js
: https://github.com/mrdoob/three.js/releases/tag/r152This enabled
ColorManagement
by default as of https://github.com/mrdoob/three.js/pull/25866 . This sounds like a pretty plausible reason for brightness changes: https://threejs.org/docs/#manual/en/introduction/Color-managementI've tried setting
ColorManagement.enabled = false
but that doesn't work, so we probably have to declare color spaces on somePG3D
related objects.