search

cubing / cubing.js

🛠 A library for displaying and working with twisty puzzles. Also currently home to the code for Twizzle.
https://js.cubing.net/cubing/
GNU General Public License v3.0
232 stars 42 forks source link

[cubing.js issue] Scale of experimental-2D-LL sides stickers is inconsistent between cubes #319

Open Jobarion opened 4 months ago

Jobarion commented 4 months ago

Steps to reproduce the issue

Configuring a TwistyPlayer with visualization="experimental-2D-LL" and a puzzle="2x2x2" or puzzle="4x4x4" produces an output that is technically correct, but the scale of the side facelets seems overly large compared to the upper facelets.

Observed behaviour

See above

🖼 Screenshots

Correct scale for 3x3x3 image Wrong scales for 2x2x2 and 4x4x4 image image

Expected behaviour

I expected relative size difference between the side, and the upper facelets to be similar for 2x2x2, 3x3x3 and 4x4x4.

Environment

https://experiments.cubing.net/cubing.js/twisty/twisty-player-config.html, on Firefox and Chrome

Additional info

No response

lgarron commented 4 months ago

This is by design, so that every sticker in a given image is roughly the same size. The sides for 3x3x3 should probably be a little bit larger.

Jobarion commented 4 months ago

I believe the relative scale of 3x3x3 looks best, the other two are a little bit disorienting in my opinion. But that's a design decision that's obviously up to you. Either way, all of them should probably be similar.