search

cubing / cubing.js

🛠 A library for displaying and working with twisty puzzles. Also currently home to the code for Twizzle.
https://js.cubing.net/cubing/
GNU General Public License v3.0
232 stars 42 forks source link

[cubing.js issue] Malformed types published with `v0.48.3` #329

Closed lgarron closed 2 months ago

lgarron commented 2 months ago

https://unpkg.com/browse/cubing@0.48.3/dist/lib/cubing/puzzles/index.d.ts contains 911 lines, duplicating some definitions with other files. This can cause spurious errors with TypeScript in downstream projects.

Contrast this with the proper 40 lines in v0.48.2: https://unpkg.com/browse/cubing@0.48.2/dist/lib/cubing/puzzles/index.d.ts

This must have happened as a result of some bad state or a race condition while I was publishing. But I've tried coming up with several theories about what specifically happened, and have not been able to reproduce the issue with any of them. I'm going to just try publishing again and see if it happens again.

lgarron commented 2 months ago

This is hopefully fixed in v0.48.4:

https://unpkg.com/browse/cubing@0.48.4/dist/lib/cubing/puzzles/index.d.ts