cubing / icons

🖼 Icons for WCA events, unofficial events, and competition-related concepts.
https://icons.cubing.net
MIT License
43 stars 22 forks source link

Add 2/3/4/8-man 3x3 Blindfolded relay icons #107

Closed dmint789 closed 1 year ago

dmint789 commented 1 year ago

This fulfills part of #105. Preview:

333bf

dmint789 commented 1 year ago

@jfly how about 333bf-Nman-relay, where N is the number of people?

jfly commented 1 year ago

how about 333bf-Nman-relay, where N is the number of people

I like this, although we should avoid dashes, as those are our folder delimiter in this repo.

@lgarron, thoughts? Sure would be nice to have a better word than "man". "cuber"? "person"?

dmint789 commented 1 year ago

@jfly But mirror blocks uses dashes

jfly commented 1 year ago

although we should avoid dashes, as those are our folder delimiter in this repo

Nevermind, you reminded me here that we're already using kebab case. Let's stay consistent!

lgarron commented 1 year ago

although we should avoid dashes, as those are our folder delimiter in this repo

Nevermind, you reminded me here that we're already using kebab case. Let's stay consistent!

That was mostly to match existing CSS names.

I would be more favor of underscores if we're okay with mixed hyphens and underscores in CSS. (I'm probably the only one using the mirror blocks icon, so renaming it is not a big concern).

dmint789 commented 1 year ago

I would prefer to either have everything in snake_case or everything in kebab-case, so if renaming mirror works, then we can go with that. We can just keep a duplicate with kebab-case so as not to break other people's stuff.

lgarron commented 1 year ago

@lgarron, thoughts? Sure would be nice to have a better word than "man". "cuber"? "person"?

Definitely in favor of "person"! That's also what the WCA website uses.

I'd go with 333_bld_N_person_relay.

dmint789 commented 1 year ago

That is so long, can we not think of something more elegant? How about 333bf_Np_relay? I strongly believe we should keep 333bf in the front, since it's just an extension of the 3x3 Blindfolded event.

lgarron commented 1 year ago

I'm fine with 333bf as a prefix to keep some consistency with the existing event, but I definitely don't consider short names elegant. I think it's much more valuable for the name to make sense without context, and I struggle to think of a situation where 333bf_N_person_relay would fundamentally cause issues.

dmint789 commented 1 year ago

Okay, I agree. Although seeing as we now have two icons with kebab-case it seems like it would make more sense to use that here too.

lgarron commented 1 year ago

Also, just checking: do all four of these events correspond to relays that people actually do?

I am generally in favor of erring on the side of too many icons, but it could be wise to encourage a slimmer set of choices to start.

dmint789 commented 1 year ago

Also, just checking: do all four of these events correspond to relays that people actually do?

I am generally in favor of erring on the side of too many icons, but it could be wise to encourage a slimmer set of choices to start.

These are all popular categories. There is also 5-man and 10-man, but I have seen very few of those. Feel free to have a look at the cubingcontests.com rankings for these events. And that is just what I've found so far.

dmint789 commented 1 year ago

@jfly I think this is all done too now

jfly commented 1 year ago

Thanks!

dmint789 commented 1 year ago

Yay, now I can use more icons! I will work on team factory and 3x3 oh bld team relay icons tomorrow, I suppose.

dmint789 commented 1 year ago

@jfly how long does it take until a new version is rolled out, and how does that process work?

jfly commented 1 year ago

I can do a release if that helps you. We don't really have a process around this.

dmint789 commented 1 year ago

I see. Let's do it after I add the other two icons, so I'm not bothering you over and over again.