cubing / icons

🖼 Icons for WCA events, unofficial events, and competition-related concepts.
https://icons.cubing.net
MIT License
44 stars 22 forks source link

Use `fantasticon` instead of `gulp`. #112

Open lgarron opened 1 year ago

lgarron commented 1 year ago

Compared to our gulp pipeline, this is:

This also changes the project organization to match other github.com/cubing projects more closely.

Closes:

lgarron commented 1 year ago

@jfly: This still needs a few fixups, and updates to the generated site. But it looks like this this will work. Any thoughts?

jfly commented 1 year ago

fantasticon looks like a good alternative for us!

Can we do one thing at a time? That is, can we do the biomejs stuff in a separate PR?

lgarron commented 1 year ago

Can we do one thing at a time? That is, can we do the biomejs stuff in a separate PR?

I don't feel comfortable introducing a new JS file without biome, but if you really want I could probably take it out.

jfly commented 1 year ago

I don't feel comfortable introducing a new JS file without biome

Could we add biomejs first, then?

lgarron commented 1 year ago

I don't feel comfortable introducing a new JS file without biome

Could we add biomejs first, then?

Not without applying it to the existing build script, which I'm not enthused about? But you seem to feel strongly about this, lemme find a way.

lgarron commented 1 year ago

I don't feel comfortable introducing a new JS file without biome

Could we add biomejs first, then?

Not without applying it to the existing build script, which I'm not enthused about? But you seem to feel strongly about this, lemme find a way.

I mean, I guess we could add biome scoped to scripts as a stub. That's a bit silly, but I guess it works.