search

cubing / mark2

Client-Side Javascript WCA-Style Scrambler
https://www.cubing.net/mark2/
7 stars 6 forks source link

Changing url hash doesn't update "Adjust Event" spinners #153

Open jfly opened 12 years ago

jfly commented 12 years ago

This means that as you navigate through your history, the Adjust Event spinners don't update. This is bad, as you can see a bunch of 3x3 rounds in the "Adjust Individual Rounds:" table, but 0 in the "Adjust Events" table.

I think the solution to this is as simple as calling initializeEventsTable() whenever the hash changes. Right now, we only call initializeEvents.

jfly commented 12 years ago

Actually, a good fix is a little more tricky than that (simply calling initializeEventsTable() results in multiple event tables, and clobbering the existing events table is bad because it makes the ui behave poorly), but I have a fix I'm going to commit to scrambler-interface soon.