cubing / twsearch

🔍 Twizzle Search — a program to find algs and scrambles for twisty puzzles
GNU General Public License v3.0
24 stars 8 forks source link

Get CI passing on `main` again. #19

Closed lgarron closed 10 months ago

lgarron commented 11 months ago

We've recently added tests to main that fail, in order to support test-driven debugging for some issues. Once we've updated the relevant code, we should make sure all tests pass on main again.

lgarron commented 11 months ago

The CLI tests are passing again, but the WASM test is still segfaulting:

https://github.com/cubing/twsearch/actions/runs/5592176276/jobs/10224270125

Run source ~/.wasmer/wasmer.sh && make test-wasm
wasmer build/wasm-test/twsearch-test.wasm
Created new moves U2 U' F2 F' R2 R'
State size is 881798[4](https://github.com/cubing/twsearch/actions/runs/5592176276/jobs/10224270125#step:7:5)0 log2 26.3939
Requiring 3[5](https://github.com/cubing/twsearch/actions/runs/5592176276/jobs/10224270125#step:7:6) bits 8 bytes per entry; 8 from identity.
Found 4 canonical move states.
Calculated canonical states in 0.0020[6](https://github.com/cubing/twsearch/actions/runs/5592176276/jobs/10224270125#step:7:7)995
For memsize 10[7](https://github.com/cubing/twsearch/actions/runs/5592176276/jobs/10224270125#step:7:8)3741[8](https://github.com/cubing/twsearch/actions/runs/5592176276/jobs/10224270125#step:7:9)24 bytesize 16777216 subshift 42 memshift 38 shardshift 20
Initializing memory in 0.000874[9](https://github.com/cubing/twsearch/actions/runs/5592176276/jobs/10224270125#step:7:10)96
Filling table at depth 0 with val 0 saw 1 (1) in 0.000515938
Filling table at depth 1 with val 0 saw 9 ([10](https://github.com/cubing/twsearch/actions/runs/5592176276/jobs/10224270125#step:7:11)) in 0.000565052
Filling table at depth 2 with val 0 saw 54 (64) in 0.000902176
Filling table at depth 3 with val 0 saw 321 (388) in 0.00238895
Solving NoScrambleName
error: RuntimeError: out of bounds memory access
    at <unnamed> (<module>[57]:0x64a1)
    at <unnamed> (<module>[58]:0x6934)
    at <unnamed> (<module>[48]:0x5531)
    at <unnamed> (<module>[[11](https://github.com/cubing/twsearch/actions/runs/5592176276/jobs/10224270125#step:7:12)0]:0x1b3bf)
    at <unnamed> (<module>[[13](https://github.com/cubing/twsearch/actions/runs/5592176276/jobs/10224270125#step:7:14)1]:0x1d22a)
╰─▶ 1: RuntimeError: out of bounds memory access
           at <unnamed> (<module>[57]:0x64a1)
           at <unnamed> (<module>[58]:0x6934)
           at <unnamed> (<module>[48]:0x5531)
           at <unnamed> (<module>[110]:0x1b3bf)
           at <unnamed> (<module>[131]:0x1d22a)
make: *** [Makefile:[15](https://github.com/cubing/twsearch/actions/runs/5592176276/jobs/10224270125#step:7:16)0: test-wasm] Error 1
Filling table at depth 4 with val 0
Error: Process completed with exit code 2.
lgarron commented 10 months ago

Fixed in https://github.com/cubing/twsearch/commit/3747f5b8de91a3a46d97328b28fd8940aed50120