Closed thehale closed 1 year ago
Here's how GitHub's rendering of the project's licenses looks as a result of the changes in this PR:
Screenshot of my fork at thehale/twsearch
Thanks for the contribution!
It would indeed be nice to show both licenses once they are applicable to the entire project (which is not the case yet), although I'd definitely like to use a .md
file extension.
GitHub will show a project's license(s) if each license is stored in a distinct file: https://github.blog/changelog/2022-05-26-easily-discover-and-navigate-to-multiple-licenses-in-repositories/
I'm not too enthused about multiple license files, but I suppose that's a reasonable tradeoff. @rokicki, any thoughts?
It would indeed be nice to show both licenses once they are applicable to the entire project (which is not the case yet)
I guess I hadn't realized that some pieces were still under a single license. I saw the one LICENSE.md
with two license texts in it and figured splitting them for GitHub's sake was an easy first contribution as I explore this codebase more.
although I'd definitely like to use a .md file extension
I can fix that easily enough :D
ohhh, my apologies, I just realized this PR is on the twsearch
repo. Everything in this repo is dual GPL and MPL, so this sounds like a good change to me.
@rokicki, sound good to you?
Sounds great to me!
-tom
On Tue, Apr 4, 2023 at 7:05 PM Lucas Garron @.***> wrote:
ohhh, my apologies, I just realized this PR is on the twsearch repo. Everything in this repo is dual MIT and GPL, so this sounds like a good change to me.
@rokicki https://github.com/rokicki, sound good to you?
— Reply to this email directly, view it on GitHub https://github.com/cubing/twsearch/pull/8#issuecomment-1496822518, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMOLSYVIYM64NTRHQK2C6DW7THPTANCNFSM6AAAAAAWPKT5RE . You are receiving this because you were mentioned.Message ID: @.***>
--
Looking good. Thanks, @thehale!
GitHub will show a project's license(s) if each license is stored in a distinct file: https://github.blog/changelog/2022-05-26-easily-discover-and-navigate-to-multiple-licenses-in-repositories/
Additionally, using an SPDX license identifier in the license file and in the README will enable machine processing of the license.