search

cubingusa / org

The cubingusa.org website
https://cubingusa.org
8 stars 7 forks source link

Add New England mailing list #150

Closed UnsolvedCypher closed 6 years ago

UnsolvedCypher commented 6 years ago

Add a page for people to sign up for a mailing list of Northeast competitions. @timreyn and I will be using this to announce competitions as we've received multiple requests for this.

(Sorry for the accidental spam- I submitted a PR #149 too soon)

jfly commented 6 years ago

@UnsolvedCypher just FYI, you shouldn't have to create a new PR if it doesn't have what you want in it, you can just push to the branch you created the PR with.

UnsolvedCypher commented 6 years ago

@jfly Because I wanted to distinguish between the Northeast and New England (since I know NY is thinking about doing this as well), I wanted to rename the branch also. Is it considered a better practice to just make that distinction in the discussion and update the old PR?

jfly commented 6 years ago

Is it considered a better practice to just make that distinction in the discussion and update the old PR?

I don't think there's any way to rename your branch without creating a new PR. That said, I don't think the branch name is terribly important (at least, as a code reviewer, I never ascribe any real meaning to it).