search

cubiq / ComfyUI_FaceAnalysis

Extension for ComfyUI to evaluate the similarity between two faces
Apache License 2.0
313 stars 40 forks source link

Node Enhancement Suggestion #21

Closed PrometheusDante closed 1 month ago

PrometheusDante commented 3 months ago

Using the Face Embeds Distance node as a filter to get the best rated generation out of a batch to then further process it requires two Face Embeds Distance nodes. One for the output image with the rating overlay and another for the one without to be passed on. Another output connector for the image without overlay would be a much appreciated convenience. Obsoleting the generate_image_overlay setting in the bottom as well.

A little illustration of the powerful effects this simple and subtle yet stylish aesthetic change would have. Just look at this horrendous workaround, the space it takes and how messy it is! face_embeds_distance_node_UNsleek_UNsmooth 0/10. ...Who would even want to use a workflow like that? That's right! No one! Not a single one! 100% of all people asked shared this exact sentiment! Downright outrageous :'(

Buuuut, you sir, can make a difference! Yes, you and only you could make this beautiful, visually pleasing pipe-dream of good taste and thoughtful UI-engineering come true! face_embeds_distance_node_sleek_smooth So simple! So sleek! So smooth!

Thank you for your time and amazing efforts!

cubiq commented 3 months ago

Image overlay takes more than a few milliseconds, especially for large batches it adds up and it is computationally expensive. That's why it's optional

PrometheusDante commented 3 months ago

I didn't know that. Could the overlay switch operate automatically by checking whether or not there is anything connected to the additional image output "eval_IMAGE"?

cubiq commented 3 months ago

not by default, no. There might be a hack to do that but it would be client side and comfy needs to work both client and server side

andupotorac commented 1 month ago

@PrometheusDante Doesn't it help that you already have the metadata for the image, and can just regenerate it without the watermark?

PrometheusDante commented 1 month ago

@andupotorac That workflow required one with overlay and one without during the same run, but that was a while ago and I can not even say if it still looks like that. I just forgot to close this issue apparently. Really not an issue anymore, but thanks