cubiq / ComfyUI_IPAdapter_plus

GNU General Public License v3.0
4.01k stars 307 forks source link

Ipadapter problem after commit c28... (comfyui won't start generating) #109

Closed patientx closed 7 months ago

patientx commented 10 months ago

PC : windows 10, 16 gb ddr4-3000, rx 6600, using directml with no additional command parameters.

Updated today with manager , and tried my usual workflow which has ipadapter included for faces, when it comes to actually generating the image , it just stops there, nothing happens. I have to close the command prompt and relaunch the app.

Loading 1 new model 0%| | 0/8 [00:00<?, ?it/s]

I was mainly using lcm so tried normal sd1.5 models , the same results. Tried different samplers , same. If I get ipadapter out of the workflow everything works correctly. So I am not updating daily , thought something in the middle changed, tried every commit and found out that it works up until "timestepping, fix" , after that the problem is here. So now I am on c28a04466b17d760a345aea41d6a593c0a312c95. (last one before that fix) . Everything works as it was before.

JarekDerp commented 7 months ago

I can confirm that even this works from the original timestepping implementation:

sigma = extra_options["sigmas"].detach().cpu().numpy()[0] if 'sigmas' in extra_options else 999999999.9

Performance-wise, it's the same as this:

        sigma = extra_options["sigmas"][0] if 'sigmas' in extra_options else None
        sigma = sigma.item() if sigma else 999999999.9

I didn't notice any speed differences.

cubiq commented 7 months ago

will be included in the next major release

cubiq commented 7 months ago

hopefully fixed