search

cubiq / ComfyUI_IPAdapter_plus

GNU General Public License v3.0
3.2k stars 240 forks source link

IPAdapterTiled crops images with 4:5 AR #406

Open Davikar opened 3 months ago

Davikar commented 3 months ago

IPAdapterTiled seems to crop images that have a slightly wider portrait aspect ratio, like 4:5 and split it into 4 tiles rather than 2.

Here's a couple of examples:

image image

It's fairly easy to replicate, make an image that is 608x768 or any 4:5 aspect ratio and send it to the tiled ip adapter.

cubiq commented 3 months ago

"almost" square pictures are cropped to a square because there's too much overlap.

Davikar commented 3 months ago

Okay. I kinda figured that was the reason. But isn't a lot of overlap still better than cropping the image? The purpose of the node is to tile the image after all. I use IP Adapters a lot when upscaling images to keep the details intact and sending it a cropped image might affect the upscaled image negatively I think?

cubiq commented 3 months ago

if the image is just shy of squareness there might be better ways (like Seam Carving) to bring them to a square. I need to run some tests, it's worthless to offer a feature that doesn't work properly