search

cubiq / ComfyUI_IPAdapter_plus

GNU General Public License v3.0
3.91k stars 293 forks source link

IpAdapter (mainly FaceID) got extremely slow over time #547

Closed TobiTomatoe closed 4 months ago

TobiTomatoe commented 4 months ago

As the title says, the IpAdapter FaceID got slower over time, to the point where the bar of the KSampler is barely moving. The behavior was hit or miss at first for the longest time when I was clicking the prompt button, meaning sometimes it was going slower causing me to just cancel the prompt, clicking prompt again and it sometimes would go faster again. Now it is just slow, no matter what. I know that my specs are not the best and it is normal that it wont be very fast with the workflows I built, since I generate at a bigger image scales using thePatchModelAddDownscale (Kohya Deep Shrink) node, however it has always been fast enough to be able to still work with it. I would also like to mention that I update comfyUI and all custom nodes on a daily basis. Has this kind of behavior already been mentioned and does someone know what I can do about it?

Operating System: Windows 11 Home 64-bit Processor: 12th Gen Intel(R) Core(TM) i5-12400F (12 CPUs), ~2.5GHz Memory: 16384MB RAM Available OS Memory: 16216MB RAM

Card name: NVIDIA GeForce RTX 3060 Manufacturer: NVIDIA Dedicated Memory: 12115 MB Shared Memory: 8108 MB

cubiq commented 4 months ago

please provide a minimal workflow that replicates the issue

TobiTomatoe commented 4 months ago

Sure. There you go ExampleWorkflow.json

Edit: Could be any workflow tho, since I don't think that it has got anything to do with the workflow itself.

cubiq commented 4 months ago

thanks, I would really appreciate if you trim it down to just the bare minimum that triggers the issue. Ideally only base nodes and ipadapter

TobiTomatoe commented 4 months ago

I'm sorry. I thought the deep shrink and freeU might be relevant, that's why I didn't remove them.

This is as basic as it can get. Here you go. ExampleWorkflow02.json

Interestingly, with everything removed it does now run consistently faster as it used to. But I need the loras, deepshrink and freeU as I used it all the time with faceID.

TobiTomatoe commented 4 months ago

I tested it again and it seems like the "PatchModelAddDownscale (Kohya Deep Shrink)" is what slows it down that extremely (probably even more in conjunction with FreeU). What a shame. It used to work well before.

cubiq commented 4 months ago

I don't know what could have caused it honestly but it's impossible to keep track of all the updates of all the extensions

TobiTomatoe commented 4 months ago

I understand that. Well, I'm glad that I at least now know which nodes don't play nice with faceID, at least on my personal machine and install. Tanks for taking the time.