cubiq / ComfyUI_IPAdapter_plus

GNU General Public License v3.0
3.79k stars 288 forks source link

support Kolors-IP-Adapter-FaceID-Plus #666

Open sipie800 opened 1 month ago

sipie800 commented 1 month ago

As the commit mentions, the faceid of kolors is supported. However I can't get the weight loaded. Which loader should be used ? Use the ipadapter_kolors.json example and it can‘t use weight from hf Kwai-Kolors/Kolors-IP-Adapter-FaceID-Plus.

_Exception: invalid IPAdapter model xxx\ComfyUI\models\ipadapter\kolorsipa-faceid-plus.bin

please provide a simple workflow if possible.

sipie800 commented 1 month ago

Sorry. I mistakes kolors IPA to FaceId. It's not supported yet.

cubiq commented 1 month ago

faceid was just released, it should be easy to port

Remember2015 commented 1 month ago

I guess FaceID-Plus of Kolors used clip-336, which is different from original FaceID-Plus?

WingeD123 commented 1 month ago

I guess FaceID-Plus of Kolors used clip-336, which is different from original FaceID-Plus?

yes, different from other faceid, but same as kolors' ipadapter

cubiq commented 1 month ago

faceid plus uses the embeds from both the clip vision (at 336 in case of Kolors) and insightface. That unfortunately makes the model for non-commercial use only.

I tried quickly to port it today, the model works but the results are not very good, I have to check if I need to do something else for proper support

wailovet commented 1 month ago

faceid plus uses the embeds from both the clip vision (at 336 in case of Kolors) and insightface. That unfortunately makes the model for non-commercial use only.

I tried quickly to port it today, the model works but the results are not very good, I have to check if I need to do something else for proper support

I also attempted to transplant one version, and it was equally not very good.

sipie800 commented 1 month ago

it's not good. I tried and figured out it does nothing more than copypasting the given face. Maybe the node has done something wrong?

cubiq commented 1 month ago

yes I believe the implementation is not entirely correct, I'll do some more testing in the coming days