search

cubiq / ComfyUI_InstantID

Apache License 2.0
1.21k stars 69 forks source link

I have tried your ComFyUI code, the results are probably better than Diffusers. What is the key for this quality ? #206

Closed vuongminh1907 closed 1 month ago

vuongminh1907 commented 1 month ago

image

cubiq commented 1 month ago

possibly I do some normalization on the embeds that diffusers doesn't. I haven't checked the code in a while, but what I know is that the official implementation is released at day one and they rarely do any optimization later. I keep testing and trying new things

vuongminh1907 commented 1 month ago

Thanks for your reply, I saw that you changed the IPAttnProcessor (Diffusers) by Attn2Replace, right ? Are there any changes you made, because I still can't figure out where you are using normalization. Thanks in advance.

cubiq commented 1 month ago

attention patching should be the same I guess, maybe some slight differences when applying kv and the controlnet. I haven't looked at diffusers code in a while, it's a monolithic library that I find frustrating to work with. Sorry I can't be of more help