search

cubiq / ComfyUI_InstantID

Apache License 2.0
1.29k stars 72 forks source link

Problem using mask #57

Closed LukeG89 closed 8 months ago

LukeG89 commented 8 months ago

I've tried using the mask option of InstantID, but the resulting image will be generated only inside the masked area.

This is the image without masking: InstantID_test_no_mask

And this with the mask applied: InstantID_test_with_mask

I think the issue is caused by ControlNet inside your node. Before the latest update I had encountered the same situation when appling the mask to ControlNet using the mask_optional of Advanced ControlNet node.

Maybe attention mask and ControlNet mask are merged together?

cubiq commented 8 months ago

as it is now you get the lowest amount of embeds bleeding. This is not (only) an attention mask but also a conditioning mask.

If you want to mask you need to define all areas like with any other conditioning mask

LukeG89 commented 8 months ago

Ah ok, my bad! I thought it worked as an attention mask like before the update! Thanks for the explanation!