cubiq / ComfyUI_InstantID

Apache License 2.0
1.14k stars 60 forks source link

Please bring back the old node!! even as legacy! #58

Closed zhoobin021 closed 6 months ago

zhoobin021 commented 6 months ago

ok so I just updated the InstantID and my workflow is ruined! the old one didn't have the following inputs: -control_net -image_kps and the controlnet had to be done separately which was great. Also, SD1.5 models could be used with the old node! it didn't work with the face but it introduced some amazing happy accident features. I know InstantID is only for SDXL, but with the old node it worked with SD1.5, but now that the new node has ControlNet baked into it, the conditioning of SDXL and SD1.5 doesn't work together and I'm getting errors with all my previous workflows! Also the new node even with the advanced one, where you can change the CN strength, it doesn't produce good results for me idk why, maybe because of using too many IPAdapters. so I ask you to please have the old node as separate please. or at least give me the old version, I'm ready to downgrade but don't know how and I really need it. Thank you.

Here's the old node that I had before updating:

Screenshot 2024-02-26 211342

cubiq commented 6 months ago

revert to the previous commit

zhoobin021 commented 6 months ago

revert to the previous commit

could you please let me know how can I do that?

zhoobin021 commented 6 months ago

ok I figured it out thanks to ChatGPT and Gemini. and help from @darkbyte from the L2 Discord server.

so go to ComfyUI\custom_nodes\ComfyUI_InstantID (cd ComfyUI\custom_nodes\ComfyUI_InstantID) [open console terminal by clicking in the address bar and typing cmd and press enter.

in the terminal type 'git log' and then copy the commit that you want to revert back to! (basically which version) for me it was : '40b86b449774424893deac1d19139abc25c02882'

then close the terminal and re-open it! not type 'git reset --hard '
(for me '' is '40b86b449774424893deac1d19139abc25c02882' ) so I put 'git reset --hard '40b86b449774424893deac1d19139abc25c02882' .

this worked for me, and I just restarted comfyui.

you can also use both updated version and the old version at the same time, Just make a copy from \ComfyUI_InstantID folder and rename to something different (e.g. \ComfyUI_InstantID-old) and go to \ComfyUI_InstantID-old and open 'InstantID.py' and at the end bottom change names for NODE_CLASS_MAPPINGS. e.g. : NODE_CLASS_MAPPINGS = { "InstantIDModelLoader-old": InstantIDModelLoader, "InstantIDFaceAnalysis-old": InstantIDFaceAnalysis, "ApplyInstantID-old": ApplyInstantID, "FaceKeypointsPreprocessor-old": FaceKeypointsPreprocessor,

and then save the file. enjoy ;)

cubiq commented 6 months ago

update to the latest version (just pushed). it also includes legacy nodes

zhoobin021 commented 6 months ago

thank you! 🙏💜 this is the one right?

image

and it doesn't need positive an negative conditioning..is that correct?