search

cubiq / ComfyUI_InstantID

Apache License 2.0
1.26k stars 71 forks source link

[Question] Why Face Analysis Preprocessor stop working with multiple images? #80

Closed LukeG89 closed 7 months ago

LukeG89 commented 7 months ago

Hi @cubiq, I have a question about multiple reference images.

In previous commits, from 3fa938f (First working version) to 5149a21, Face Analysis preprocessor was working with multiple images, both using single images and video frames.

Face_Analysis_with_batches

https://github.com/cubiq/ComfyUI_InstantID/assets/161304036/c395007a-f63f-442a-a3e0-4578233ff942

But after 6938fc7 (bugfix), Face Analysis only recognize the first image. Why is that?

Thanks a lot!

cubiq commented 7 months ago

this was done because you can send a batch of reference images that are averaged, but only 1 kps position was used.

now you can send a batch of images for the kps image

LukeG89 commented 7 months ago

Great update, @cubiq! Thank you very much!

Now I go off-topic and start speaking italian (in italic of course): Volevo cogliere l'occasione per ringraziarti di tutto ciò che fai per questa community, apprezzo moltissimo l'impegno che ci metti nel tuo lavoro e la passione che hai anche nell'insegnare. Sei davvero fantastico, Matteo! Continua così! :)

cubiq commented 7 months ago

grazie!