search

cubiq / SwipeView

Virtually infinite loop-able horizontal carousel
MIT License
698 stars 167 forks source link

Go to page no loop fix #34

Closed ebi closed 10 years ago

ebi commented 12 years ago

If you disable looping and use a goToPage the masterPage 0 will stay as invisible but potentially the next page will be visible (which shouldn't) I didn't fully understand the system but removing the visibility hidden and rechecking the position seems to fix the situation.

jmohsenin commented 11 years ago

+1 this solved my issue. Thanks guys!

dokterbob commented 10 years ago

I have fired a new pull request with just @linlex patch, for which many thanks!

@ebi Perhaps a good idea to close this pull request to prevent people from applying a patch with known issues.

ebi commented 10 years ago

@dokterbob I haven't tried the @linlex fix. So I trust you on that one. Unfortunately it doesn't seem like @cubiq is merging stuff anyways.

dokterbob commented 10 years ago

Yeah, quite a pity. Perhaps he will some time in the future.

Thanks for the quick reaction.