isMobileChrome not correctly detected

cubiq / add-to-homescreen

Add to home screen call-out for mobile devices

http://cubiq.org/add-to-home-screen

2.29k stars 747 forks source link

isMobileChrome not correctly detected #240

Open princeofnaxos opened 7 years ago

princeofnaxos commented 7 years ago

isMobileChrome looks if 'Android' appears in the navigator name, but there is also Chrome for iOS.

Moreover, the message is incorrect for Chrome browsers in iOS, since there is no 'Add to Home screen' option in the share menu. So, there should be more messages to tell the Chrome for iOS user that she should open the site in Safari and then click the Share button.

emmercm commented 7 years ago

This is still an issue. Here is an example user-agent I'm working with:

Mozilla/5.0 (iPhone; CPU iPhone OS 9_0_1 like Mac OS X) AppleWebKit/601.1 (KHTML, like Gecko) CriOS/47.0.2526.107 Mobile/13A405 Safari/601.1.46

thewinger commented 7 years ago

+1 with this error