search

cubos / rethinkdb.cr

RethinkDB Driver for Crystal
MIT License
34 stars 4 forks source link

add UUID support for crystal 24 breaking changes #8

Closed kingsleyh closed 6 years ago

kingsleyh commented 6 years ago

this is a fix for the SecureRandom breaking change in crystal 24 - Ive just started crystal - so the fix might be rubbish

lbguilherme commented 6 years ago

This adds UUID, which is great. But you mentioned SecureRandom, but doesn't touch it. Is it missing some commit?

kingsleyh commented 6 years ago

No that was everything - I’m not exactly sure why it was impacted - maybe when in crystal 23 - SecureRamdom was getting turned into a string but with UUID it doesn’t? I followed the error and fixed where it happened but I guess maybe a fix would be possible outside of RethinkDB I’m not sure

lbguilherme commented 6 years ago

Ok, thanks. I'll accept this and then check if anything else it needed for 0.24

kingsleyh commented 6 years ago

Great thanks - this is a great library - I'll try to contribute to it - I'm particularly interested in append, set_insert and joins

lbguilherme commented 6 years ago

Please hold on. I'm working on a substitute for this library and as soon as it is feature equivalent to this one, I'll release and replace it. I expect it in one week or two.

Actually, it might be easy to just add those here, if you will. In case you need them before that.

lbguilherme commented 6 years ago

@kingsleyh Take a look at https://github.com/lbguilherme/rethinkdb-lite

kingsleyh commented 6 years ago

wow very ambitious - looks awesome. Is the idea to start using it for the client part as a replacement for this library - and then eventually replace the server as well

kingsleyh commented 6 years ago

One potential issue could be the lack of windows support - I don't know if many people use rethinkdb on windows. I use OSX and Linux so personally I don't care about windows support.

lbguilherme commented 6 years ago

That's correct. The client is mostly easy. The server is an epic goal.

There are many things missing from Crystal right now, the most important are multi-threading and Windows support. I'm just leaving those for the future. They will be implemented much before I come close to end the server part, so I'm not really caring for now.